Skip to content

refactor(router-core): skip beforeLoad/loader store updates if these options aren't provided #4920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

refactor(router-core): skip beforeLoad/loader store updates if these options aren't provided #4920

wants to merge 9 commits into from

Conversation

@Sheraff
Copy link
Contributor

@Sheraff Sheraff commented Aug 11, 2025 •
edited
Loading

Following #4916, this PR keeps reducing the number of store updates (__store.setState through updateMatch).

  • skip route.options.beforeLoad() call, and related updateMatch calls before and after, if beforeLoad is not specified
  • skip route.options.loader() call, and related updateMatch calls before and after, if loader is not specified
  • skip route.options.head(), route.options.scripts(), and route.options.headers() calls, and related updateMatch call after, if these options are not specified

Additionally, head, scripts and headers are now called in parallel. They don't depend on one another, and so there is no reason to delay their execution by calling them serially.

The store-updates-during-navigation test tracking the number of executions of a useRouterState > select method during a navigation goes from 19 calls without this PR, to 14 calls with this PR.

Should be a partial improvement of #4359

@nx-cloud
Copy link

nx-cloud bot commented Aug 11, 2025 •
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.

View your CI Pipeline Execution ↗ for commit b0d8c8f

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 5m 45s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 40s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-11 17:36:51 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 11, 2025 •
edited
Loading

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4920

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4920

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4920

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4920

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4920

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4920

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@4920

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4920

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4920

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4920

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4920

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4920

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4920

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4920

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4920

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4920

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4920

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@4920

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4920

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4920

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4920

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4920

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4920

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4920

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4920

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4920

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4920

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4920

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@4920

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4920

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4920

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4920

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4920

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@4920

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4920

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4920

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4920

commit: b0d8c8f

@Sheraff Sheraff changed the title refactor(router-core): skip beforeLoad store updates if there is no beforeLoad refactor(router-core): skip beforeLoad/loader store updates if these options aren't provided Aug 11, 2025
@Sheraff Sheraff closed this Aug 16, 2025
@Sheraff Sheraff deleted the refactor-router-core-skip-before-load-when-absent branch August 16, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: react-router package: router-core package: solid-router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sheraff @tannerlinsley